feat(Toc): add component #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chelentos
force-pushed
the
chelentos/DATAUI-1588
branch
from
07f6462 to
c45cb01
Compare
chelentos
force-pushed
the
chelentos/DATAUI-1588
branch
from
c45cb01 to
e6faddb
Compare
|
Preview is ready. |
amje
requested changes
Sep 2, 2023
|
Also I'd use |
imechoim
reviewed
Sep 4, 2023
| export const TocItem = (props: TocItemProps) => { | ||
| const {childItem = false, active = false, onClick, title, value} = props; | ||
|
|
||
| const handleClick = () => onClick(value); |
There was a problem hiding this comment.
Please, Wrap it in React.useCallback.
chelentos
force-pushed
the
chelentos/DATAUI-1588
branch
from
e6faddb to
42a116f
Compare
chelentos
force-pushed
the
chelentos/DATAUI-1588
branch
from
4cdb8e3 to
bd60842
Compare
amje
requested changes
Sep 14, 2023
amje
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.